git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 15/15] merge-recursive: switch directory rename detection default

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Mar 30, 2019, 09:12 UTC
Message-ID
<87imw0afp4.fsf@evledraar.gmail.com>
In-Reply-To
<20190330003336.21940-16-newren@gmail.com>
On Sat, Mar 30 2019, Elijah Newren wrote:
I may have more, just quickly skimming this for the first time...
Show 22 quoted lines
>  merge.renames::
> -	Whether and how Git detects renames.  If set to "false",
> -	rename detection is disabled. If set to "true", basic rename
> -	detection is enabled.  Defaults to the value of diff.renames.
> +	Whether Git detects renames.  If set to "false", rename detection
> +	is disabled. If set to "true", basic rename detection is enabled.
> +	Defaults to the value of diff.renames.
> [...]
> +	if (!git_config_get_string("merge.directoryrenames", &value)) {
> +		if (!strcasecmp(value, "true"))
> +			opt->detect_directory_renames = 2;
> +		else if (!strcasecmp(value, "false"))
> +			opt->detect_directory_renames = 0;
> +		else if (!strcasecmp(value, "conflict"))
> +			opt->detect_directory_renames = 1;
> +		else {
> +			error(_("Invalid value for merge.directoryRenames: %s"),
> +			      value);
> +			opt->detect_directory_renames = 1;
> +		}
> +		free(value);
> +	}

Instead of making your own true/false parser you can use git_parse_maybe_bool(). See what we do for merge.ff:

    builtin/merge.c-617-    else if (!strcmp(k, "merge.ff")) {
    builtin/merge.c:618:            int boolval = git_parse_maybe_bool(v);
    builtin/merge.c-619-            if (0 <= boolval) {
    builtin/merge.c-620-                    fast_forward = boolval ? FF_ALLOW : FF_NO;
    builtin/merge.c-621-            } else if (v && !strcmp(v, "only")) {
    builtin/merge.c-622-                    fast_forward = FF_ONLY;
    builtin/merge.c-623-            } /* do not barf on values from future versions of git */
    builtin/merge.c-624-            return 0;

Small nit, but allows us to document "this config takse bool or ..." without having different verions of "bool" in various places.

Also, I don't care personally, but this also violates the "if one thing requires braces put it on all the if/else arms" in CodingGuidelines.

Previous: Elijah NewrenNext: Elijah Newren
Message 27 of 49 in “[BUG] All files in folder are moved when cherry-picking commit that moves fewer files”
  1. Linus NilssonFeb 27, 2019
  2. Phillip WoodFeb 27, 2019
  3. Elijah NewrenFeb 27, 2019
  4. Jeff KingFeb 27, 2019
  5. Elijah NewrenFeb 27, 2019
  6. Linus NilssonFeb 28, 2019
  7. Junio C HamanoMar 1, 2019
  8. Elijah NewrenMar 2, 2019
  9. Junio C HamanoMar 3, 2019
  10. Elijah NewrenMar 6, 2019
  11. Junio C HamanoMar 6, 2019
  12. Elijah NewrenMar 7, 2019
  13. Junio C HamanoMar 7, 2019
  14. Junio C HamanoMar 7, 2019
  15. 00/15 Switch directory rename detection defaultElijah Newren, Mar 30, 2019
  16. 08/15 merge-recursive: remove ren[12]_other fields from rename_conflict_infoElijah Newren, Mar 30, 2019
  17. 10/15 merge-recursive: cleanup handle_rename_* function signaturesElijah Newren, Mar 30, 2019
  18. 01/15 Use 'unsigned short' for mode, like diff_filespec doesElijah Newren, Mar 30, 2019
  19. 04/15 merge-recursive: rename locals 'o' and 'a' to 'obuf' and 'abuf'Elijah Newren, Mar 30, 2019
  20. 14/15 merge-recursive: give callers of handle_content_merge() access to contentsElijah Newren, Mar 30, 2019
  21. 11/15 merge-recursive: switch from (oid,mode) pairs to a diff_filespecElijah Newren, Mar 30, 2019
  22. 07/15 merge-recursive: shrink rename_conflict_infoElijah Newren, Mar 30, 2019
  23. 12/15 t6043: fix copied test description to match its purposeElijah Newren, Mar 30, 2019
  24. 09/15 merge-recursive: track branch where rename occurred in rename structElijah Newren, Mar 30, 2019
  25. 13/15 merge-recursive: track information associated with directory renamesElijah Newren, Mar 30, 2019
  26. 15/15 merge-recursive: switch directory rename detection defaultElijah Newren, Mar 30, 2019
  27. Ævar Arnfjörð BjarmasonMar 30, 2019
  28. Elijah NewrenApr 1, 2019
  29. 02/15 merge-recursive: rename merge_options argument from 'o' to 'opt'Elijah Newren, Mar 30, 2019
  30. 05/15 merge-recursive: use 'ci' for rename_conflict_info variable nameElijah Newren, Mar 30, 2019
  31. 03/15 merge-recursive: rename diff_filespec 'one' to 'o'Elijah Newren, Mar 30, 2019
  32. 06/15 merge-recursive: move some struct declarations togetherElijah Newren, Mar 30, 2019
  33. 00/15 Switch directory rename detection defaultElijah Newren, Apr 5, 2019
  34. 03/15 merge-recursive: rename diff_filespec 'one' to 'o'Elijah Newren, Apr 5, 2019
  35. 05/15 merge-recursive: use 'ci' for rename_conflict_info variable nameElijah Newren, Apr 5, 2019
  36. 09/15 merge-recursive: track branch where rename occurred in rename structElijah Newren, Apr 5, 2019
  37. 06/15 merge-recursive: move some struct declarations togetherElijah Newren, Apr 5, 2019
  38. 07/15 merge-recursive: shrink rename_conflict_infoElijah Newren, Apr 5, 2019
  39. 08/15 merge-recursive: remove ren[12]_other fields from rename_conflict_infoElijah Newren, Apr 5, 2019
  40. 04/15 merge-recursive: rename locals 'o' and 'a' to 'obuf' and 'abuf'Elijah Newren, Apr 5, 2019
  41. 15/15 merge-recursive: switch directory rename detection defaultElijah Newren, Apr 5, 2019
  42. 14/15 merge-recursive: give callers of handle_content_merge() access to contentsElijah Newren, Apr 5, 2019
  43. 12/15 t6043: fix copied test description to match its purposeElijah Newren, Apr 5, 2019
  44. 13/15 merge-recursive: track information associated with directory renamesElijah Newren, Apr 5, 2019
  45. 02/15 merge-recursive: rename merge_options argument from 'o' to 'opt'Elijah Newren, Apr 5, 2019
  46. 10/15 merge-recursive: cleanup handle_rename_* function signaturesElijah Newren, Apr 5, 2019
  47. 01/15 Use 'unsigned short' for mode, like diff_filespec doesElijah Newren, Apr 5, 2019
  48. 11/15 merge-recursive: switch from (oid,mode) pairs to a diff_filespecElijah Newren, Apr 5, 2019
  49. Jacob KellerApr 5, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.