Re: [PATCH] bundle-uri: plug leak in unbundle_from_file()

From: Toon Claes <toon@iotcl.com>
Date: Oct 1, 2024, 18:58 UTC
Message-ID: <87ikubsl9a.fsf@iotcl.com>
In-Reply-To: <xmqqle0jmfpf.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 5 quoted lines

> Thanks for reviewing carefully.
>
> Both of two callers of unbundle_from_file() are used as the
> condition of an if() statement, so unbundle() that signals an error
> with -1 wouldn't be a problem, I would think.

Hi Junio,

I've noticed this patch wasn't picked up yet. Is there anything you want me to change and have me sent another version, or is it good to go in?

-- Toon