Re: [PATCH] graph API: Added logic for colored edges
- From
- Teemu Likonen <tlikonen@iki.fi>
- Date
- Apr 9, 2009, 17:58 UTC
- Message-ID
- <87hc0x7lpg.fsf@iki.fi>
- In-Reply-To
- <20090407185724.GA9996@linux.vnet>
On 2009-04-07 14:57 (-0400), Allan Caffee wrote:
> Modified the graph drawing logic to colorize edges based on > parent-child relationships similiarly to gitk.
I like the colored graph very much, thanks. Unfortunately there are some problems with aligning of log messages and headers. For example, try this in git.git repository:
$ git log -1 --graph 796b137
* commit 796b13781aecce551b8f92049a66646e60f31dce |\ Merge: 6da14ee db12d97 | | Author: Junio C Hamano <gitster@pobox.com> | | Date: 2009-04-08 23:41:27 -0700
Without colors or without your patch the alignment is correct:
$ git log -1 --graph --no-color 796b137
* commit 796b13781aecce551b8f92049a66646e60f31dce |\ Merge: 6da14ee db12d97 | | Author: Junio C Hamano <gitster@pobox.com> | | Date: 2009-04-08 23:41:27 -0700
(Perhaps the "Merge:" header could have two spaces befor the data, but this is unrelated to --graph.)