Re: [PATCH] tag -d: print sha1 of deleted tag
- From
Jari Aalto <jari.aalto@cante.net>
- Date
- Dec 10, 2009, 13:16 UTC
- Message-ID
- <87hbrz6kbs.fsf@jondo.cante.net>
- In-Reply-To
- <20091210124929.GA444@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 9 quoted lines
> On Thu, Dec 10, 2009 at 01:23:43PM +0100, Michael J Gruber wrote: > >> Print the sha1 of the deleted tag (in addition to the tag name) so that >> one can easily recreate a mistakenly deleted tag: >> >> git tag -d tagname >> Deleted tag 'tagname' DEADBEEF >> git tag 'tagname' DEADBEEF # for lightweight tags >> git update-ref refs/tags/'tagname' DEADBEEF # for annotated tags
> That being said, I am not a fan of the cut-and-paste format. This is not > something that happens so frequently
It dpends on user. For me it it does.
Show 5 quoted lines
> 1. It is not immediately obvious to a user seeing this message > for this first time exactly what the trailing sha1 means. > > 2. Even if they know what it means, it is not immediately obvious that > the error line is meant to be cut-and-pasted.
"not meant" specifically, but it's very convenient to have it in format that happens to be "cut-n-paste ready". The SHA itself is easily understood in the context.
Thanks for all that have so quickly implemented this, Jari