git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[GUILT] [PATCH] Handle empty patches and patches with only a header.

From
Per Cederqvist <cederp@opera.com>
Date
Apr 30, 2012, 10:29 UTC
Message-ID
<87haw1342k.fsf@opera.com>

"git apply --numstat" in Git 1.7.10 gives an error message unless the patch contains a diff, so don't attempt to apply it unless we find a

Signed-off-by: Per Cederqvist <cederp@opera.com>
---
 guilt |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/guilt b/guilt
index 5d619c5..66a671a 100755
--- a/guilt
+++ b/guilt
@@ -622,7 +622,7 @@ push_patch()
 		cd_to_toplevel
 
 		# apply the patch if and only if there is something to apply
-		if [ `git apply --numstat "$p" | wc -l` -gt 0 ]; then
+		if grep -q '^diff ' "$p" && [ `git apply --numstat "$p" | wc -l` -gt 0 ]; then
 			if [ "$bail_action" = abort ]; then
 				reject=""
 			fi
-- 
1.7.10
Next: Jeff Sipek
Message 1 of 3 in “Handle empty patches and patches with only a header.”
  1. Per CederqvistApr 30, 2012
  2. Jeff SipekApr 30, 2012
  3. Per CederqvistMay 2, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.