Re: [PATCH] Revert "graph.c: mark private file-scope symbols as static"
- From
Thomas Rast <trast@student.ethz.ch>
- Date
- Mar 2, 2013, 19:16 UTC
- Message-ID
- <87haktwr2a.fsf@pctrast.inf.ethz.ch>
- In-Reply-To
- <50e7b3316fadbb550bea098ae92a0942a4429647.1362228122.git.john@keeping.me.uk>
John Keeping <john@keeping.me.uk> writes:
Show 17 quoted lines
> This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb. > > CGit uses these symbols to output the correct HTML around graph > elements. Making these symbols private means that CGit cannot be > updated to use Git 1.8.0 or newer, so let's not do that. > > Signed-off-by: John Keeping <john@keeping.me.uk> > --- > > I realise that Git isn't a library so making the API useful for outside > projects isn't a priority, but making these two methods public makes > life a lot easier for CGit. > > Additionally, it seems that Johan added graph_set_column_colors > specifically so that CGit should use it - there's no value to having > that as a method just for its use in graph.c and he was the author of > CGit commit 268b34a (ui-log: Colorize commit graph, 2010-11-15).
Perhaps you could add a comment in the source to prevent this from happening again?
--
Thomas Rast
trast@{inf,student}.ethz.ch