git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Revert "graph.c: mark private file-scope symbols as static"

From
Thomas Rast <trast@student.ethz.ch>
Date
Mar 2, 2013, 19:16 UTC
Message-ID
<87haktwr2a.fsf@pctrast.inf.ethz.ch>
In-Reply-To
<50e7b3316fadbb550bea098ae92a0942a4429647.1362228122.git.john@keeping.me.uk>
John Keeping <john@keeping.me.uk> writes:
Show 17 quoted lines
> This reverts commit ba35480439d05b8f6cca50527072194fe3278bbb.
>
> CGit uses these symbols to output the correct HTML around graph
> elements.  Making these symbols private means that CGit cannot be
> updated to use Git 1.8.0 or newer, so let's not do that.
>
> Signed-off-by: John Keeping <john@keeping.me.uk>
> ---
>
> I realise that Git isn't a library so making the API useful for outside
> projects isn't a priority, but making these two methods public makes
> life a lot easier for CGit.
>
> Additionally, it seems that Johan added graph_set_column_colors
> specifically so that CGit should use it - there's no value to having
> that as a method just for its use in graph.c and he was the author of
> CGit commit 268b34a (ui-log: Colorize commit graph, 2010-11-15).

Perhaps you could add a comment in the source to prevent this from happening again?

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Johan HerlandNext: John Keeping
Message 3 of 14 in “Revert "graph.c: mark private file-scope symbols as static"”
  1. Revert "graph.c: mark private file-scope symbols as static"John Keeping, Mar 2, 2013
  2. Johan HerlandMar 2, 2013
  3. Thomas RastMar 2, 2013
  4. John KeepingMar 3, 2013
  5. Junio C HamanoMar 3, 2013
  6. John KeepingMar 3, 2013
  7. Junio C HamanoMar 3, 2013
  8. John KeepingMar 3, 2013
  9. Junio C HamanoMar 3, 2013
  10. Revert "graph.c: mark private file-scope symbols as static"John Keeping, Mar 4, 2013
  11. Jason A. DonenfeldMar 4, 2013
  12. Junio C HamanoMar 4, 2013
  13. Jason A. DonenfeldMar 4, 2013
  14. Johan HerlandMar 4, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.