Re: [RFC] Rebasing merges: a jorney to the ultimate solution(RoadClear)

From: Sergey Organov <sorganov@gmail.com>
Date: Mar 30, 2018, 16:36 UTC
Message-ID: <87h8oxwmfg.fsf@javad.com>
In-Reply-To: <nycvar.QRO.7.76.6.1803301537250.5026@qfpub.tvgsbejvaqbjf.bet>

Hi Johannes,

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 16 quoted lines

> Hi Sergey,
>
> On Wed, 28 Mar 2018, Sergey Organov wrote:
>
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>> 
>> > I use rebase every day. I use the Git garden shears every week. If you
>> > do not trust my experience with these things, nothing will convince
>> > you. 
>> 
>> Unfortunately you have exactly zero experience with rebasing merges as
>> you've never actually rebased them till now, and it's rebasing merges
>> that matters in this particular discussion.
>
> Who says that I have 0 experience with that? Oh yes, you do. Like, as if
> you know.

I just didn't see even single symptom of it in the discussion, still I said nothing about it until you started to use your presumed experience in place of true arguments.

> Guess what I do with those Git garden shears' merges? Can you guess? Of
> course you can. But you'll never know until I tell you. It is a little
> silly to try to tell me that I do not have any experience with rebasing
> merges when you have no idea what strategies I tried in the past.

Please notice that I never even started to discuss your 'merge' directive, exactly because I believe you have huge experience both implementing and using it that could be relied upon. Just don't mix-in rebasing merge commits into it, as that is fundamentally different operation.

And the other unspoken strategies you tried are irrelevant here, as you declined the whole idea of replaying merge-the-commit instead of replaying merge-the-operation until recently, and it seems you still do, at least to some level, by attempting to use 'merge' operation to replay "the (merge) _commit_". I'm afraid that whatever you've tried in the past likely suffered from the same conceptual confusion, and thus did not work indeed.

That said, negative experience is still an experience, often helpful, but what is relevant here is that it likely was not about rebasing merge commits at all, so trying to use this irrelevant experience in the discussion to support your arguments, or rather lack of them, seems even more unfair to me then using relevant experience for that purpose.

> Now, Phillip's strategy is clearly the best strategy I ever heard
> about,

For 'pick' vs 'merge', it's not about strategy, it's about concept. It looks like you still believe that you somehow "merge" a merge commit when you actually rebase it (with Phillip's strategy if you wish). You don't merge it anywhere, period.

> and I am in the process of doing Actual Work to Put It To The Test.

That's the best outcome of the discussion I ever hoped for, seriously, and I'll be all ears to listen to the outcomes of the experience you will gain with it.

BTW, when you have it working, use the strategy you've implemented for non-merge commits as well, as a good one should still work fine. Moreover, it should better bring exactly the same results as the default existing strategy being used for non-merge commits, even in conflicting situations.

Hopefully /that/ experience will finally push you strong enough to get the concept right, and you will finally understand that what you've implemented is nothing else but a _cherry-pick_ of a _merge commit_, that reads simply _pick_, for brevity.

-- Sergey