Re: should config options be treated as case-sensitive?
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- May 22, 2018, 12:13 UTC
- Message-ID
- <87h8mz99d2.fsf@evledraar.gmail.com>
- In-Reply-To
- <alpine.LFD.2.21.1805220353370.989@localhost.localdomain>
On Tue, May 22 2018, Robert P. J. Day wrote:
Show 36 quoted lines
> in my wanderings, more oddities, such as this:
>
> $ grep -ir blankboundary *
> builtin/blame.c: if (!strcmp(var, "blame.blankboundary")) {
> Documentation/config.txt:blame.blankBoundary::
> Documentation/blame-options.txt: be controlled via the `blame.blankboundary` config option.
> Documentation/RelNotes/2.15.1.txt: * Description of blame.{showroot,blankboundary,showemail,date}
> Documentation/RelNotes/2.16.0.txt: * Description of blame.{showroot,blankboundary,showemail,date}
> $
>
> where you can see the single instance of "blankBoundary" in
> Doc/config.txt (with the upper case 'B'), while the rest have no such
> thing.
>
> for fun, i checked another of blame's config settings, with similar
> results:
>
> builtin/blame.c: if (!strcmp(var, "blame.showemail")) {
> Documentation/config.txt:blame.showEmail::
> Documentation/RelNotes/2.15.1.txt: * Description of blame.{showroot,blankboundary,showemail,date}
> Documentation/RelNotes/2.5.0.txt: * "git blame" learned blame.showEmail configuration variable.
> Documentation/RelNotes/2.16.0.txt: * Description of blame.{showroot,blankboundary,showemail,date}
> Documentation/git-blame.txt: This can also be controlled via the `blame.showEmail` config
> t/t8002-blame.sh:test_expect_success 'setup showEmail tests' '
> t/t8002-blame.sh:test_expect_success 'blame with showemail options' '
> t/t8002-blame.sh:test_expect_success 'blame with showEmail config false' '
> t/t8002-blame.sh: git config blame.showEmail false &&
> t/t8002-blame.sh:test_expect_success 'blame with showEmail config true' '
> t/t8002-blame.sh: git config blame.showEmail true &&
>
> thoughts?
>
> rday
>
> p.s. i am not *trying* to be annoyingly pedantic, i am merely
> succeeding.The issues you note about the docs using foo.barbaz instead of foo.barBaz should be fixed, but as noted in the "Syntax" section of "git-config" we already document that the config keys are all case-insensitive. We just like talking about them as foo.barBaz because it makes for easier reading.