Re: [PATCH] Adding menu for Emacs git.el

From

AJAlexandre Julliard <julliard@winehq.org>

Date

Dec 2, 2007, 18:42 UTC

Message-ID

<87fxylos4o.fsf@wine.dyndns.org>

In-Reply-To

<87mysvfr7e.dlv@vanicat.homelinux.org>

> Adding three menu to the git-status-mode of git.el : One for marking
> and unmarking, one for every thing you need when you have a conflict,
> and a last one for all the rest.
>
> Signed-off-by: Rémi Vanicat <vanicat@debian.org>

It looks good to me. A couple of minor details:

> +      ["Interctive Diff File" git-diff-file-idiff t]

There's a typo here.

> +      ["Show Uptodate" git-toggle-show-uptodate :style toggle :selected git-show-uptodate]
> +      ["Toggle Show Ignored" git-toggle-show-ignored :style toggle :selected git-show-ignored]
> +      ["Toggle Show Unknown" git-toggle-show-unknown :style toggle :selected git-show-unknown]))

I'd get rid of 'Toggle' on the last two for consistency.

BTW do you have a copyright assignment for Emacs?

-- 
Alexandre Julliard
julliard@winehq.org