Re: [PATCH 2/2] test output: respect $TEST_OUTPUT_DIRECTORY

From: Thomas Rast <trast@inf.ethz.ch>
Date: Apr 29, 2013, 18:00 UTC
Message-ID: <87fvy9dxok.fsf@hexa.v.cablecom.net>
In-Reply-To: <47c9ba4200a22e865040208628357d9bc4bcf3f4.1367002553.git.john@keeping.me.uk>

John Keeping <john@keeping.me.uk> writes:

Show 15 quoted lines

> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index ca6bdef..70ad085 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -54,8 +54,8 @@ done,*)
>  	# do not redirect again
>  	;;
>  *' --tee '*|*' --va'*)
> -	mkdir -p test-results
> -	BASE=test-results/$(basename "$0" .sh)
> +	mkdir -p "$(TEST_OUTPUT_DIRECTORY)/test-results"
> +	BASE="$(TEST_OUTPUT_DIRECTORY)/test-results/$(basename "$0" .sh)"
>  	(GIT_TEST_TEE_STARTED=done ${SHELL_PATH} "$0" "$@" 2>&1;
>  	 echo $? > $BASE.exit) | tee $BASE.out
>  	test "$(cat $BASE.exit)" = 0

Hmm, I initially was too lazy to review this change, and now it's biting me. The above is Makefile-quoted, which to the shell reads like a command substitution.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch