Re: [PATCH 1/2] t9902: fix 'test A == B' to use = operator
- From
Thomas Rast <trast@inf.ethz.ch>
- Date
- Jul 9, 2013, 09:27 UTC
- Message-ID
- <87fvvogk1x.fsf@linux-k42r.v.cablecom.net>
- In-Reply-To
- <7v1u790xzj.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 13 quoted lines
> Thomas Rast <trast@inf.ethz.ch> writes: > >> The == operator as an alias to = is not POSIX. This doesn't actually >> matter for the execution of the script, because it only runs when the >> shell is bash. However, it trips up test-lint, so it's nicer to use >> the standard form. > > OK, my knee-jerk reaction was "this is only for bash" as you said, > but the test-lint part I agree with. > > But then test-lint _ought_ to also catch the use of "local" in the > ideal world, so perhaps in the longer term we would need to treat > this bash-only script differently from others anyway???
True. I didn't really think about wider implications; I just noticed that there was an easy-to-fix complaint from test-lint :-)
--
Thomas Rast
trast@{inf,student}.ethz.ch