Re: [PATCH] graph.c: visual difference on subsequent series
- From
Keshav Kini <keshav.kini@gmail.com>
- Date
- Oct 28, 2013, 16:59 UTC
- Message-ID
- <87fvrljpq4.fsf@gmail.com>
- In-Reply-To
- <xmqqeh75h087.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
> [administrivia: please avoid culling addresses from To:/Cc: lines]
Yikes, sorry about that. I've been sending messages through Gmane rather than via email, and I didn't realize the list didn't automatically send messages to the appropriate people who are only reading the list via actual email (as I am not such a person).
Show 52 quoted lines
> Keshav Kini <keshav.kini@gmail.com> writes: >> What about just putting an extra blank line after every root commit line >> (possibly except the last one)? That should make it plenty easy to see >> where the root commits are in --oneline mode. I think it would actually >> be easier to spot at a glance than replacing `*` with `x` because it >> creates a gap in all columns of the output, rather than only in column >> 1. Also, this is very subjective but I think it looks kind of ugly to >> use "x" :P > > I agree to all of the above, including the ugliness of 'x' ;-) > > A "blank" may however be hard to spot, if the range is limited, > though. For example, > > $ git log --graph --oneline a4.. > * HEAD > /* a1 > | * a2 > | * a3 > * b1 > * b2 > * b3 > > where "a4", which is a root, is the sole parent of "a3" and HEAD is > a merge between "a1" and "b1" might produce something like this, > while we may get this from the same history, when shown unlimited: > > $ git log --graph --oneline > * HEAD > /* a1 > | * a2 > | * a3 > | * a4 > | > * b1 > * b2 > * b3 > > A divider line might make it visually a lot more strong, i.e. > > $ git log --graph --oneline > * HEAD > /* a1 > | * a2 > | * a3 > | * a4 > | ~~~~~~~~~~~~~~~~~~~~~~~ > * b1 > * b2 > * b3 > > but I am not sure if it is too distracting.
I would be fine with that, fwiw. We can also turn it on and off with a config option if people really don't like it, I suppose...
-Keshav