git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t0050: remove the unused $test_case variable

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Feb 7, 2018, 08:07 UTC
Message-ID
<87fu6dz0h6.fsf@evledraar.gmail.com>
In-Reply-To
<bf3ad52d-4aa3-8678-9466-3996f6cba11c@kdbg.org>
On Wed, Feb 07 2018, Johannes Sixt jotted:
Show 11 quoted lines
> Am 07.02.2018 um 00:13 schrieb Ævar Arnfjörð Bjarmason:
>> The $test_case variable hasn't been used since
>> decd3c0c28 ("t0050-*.sh: mark the rename (case change) test as
>> passing", 2014-11-28) when its last user went away.
>>
>> Let's remove the "say" as well, since it's obvious from subsequent
>> output that we're testing on a case sensitive filesystem.
>
> Am I misunderstanding the message? I think it reports properties of
> the test environment. And the tests do run on case-insensitive
> filesystems. IMO, the message should be kept.

It's obvious from subsequent output whether the FS is case sensitive or not, so I thought it was redundant to keep this report at the top since we didn't have the variable setting anymore.

Previous: Johannes SixtNext: Johannes Sixt
Message 3 of 5 in “t0050: remove the unused $test_case variable”
  1. t0050: remove the unused $test_case variableÆvar Arnfjörð Bjarmason, Feb 6, 2018
  2. Johannes SixtFeb 7, 2018
  3. Ævar Arnfjörð BjarmasonFeb 7, 2018
  4. Johannes SixtFeb 7, 2018
  5. Ævar Arnfjörð BjarmasonFeb 7, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.