Re: [PATCH] reftable: fix tests being broken by NFS' delete-after-close semantics

From: Toon Claes <toon@iotcl.com>
Date: Mar 22, 2024, 15:15 UTC
Message-ID: <87frwiuwlb.fsf@to1.studio>
In-Reply-To: <8ac5e94a3930cdd2aee9ea86acda3155674b635c.1711035529.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 6 quoted lines

> Fix this bug by skipping over any files that start with a leading dot
> when counting files. While we could explicitly check for a prefix of
> ".nfs", other network file systems like SMB for example do the same
> trickery but with a ".smb" prefix. In any case though, this loosening of
> the assertion should be fine given that the reftable library would never
> write files with leading dots by itself.

I'm fully supportive of this, as this will also fix any issues possibly caused by .DS_Store files created by Finder on macOS, although it's very unlikely they will be created in these tests.

-- Toon