git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: fix multi selected file operation

From
Pat Thoyts <patthoyts@users.sourceforge.net>
Date
Oct 15, 2011, 22:48 UTC
Message-ID
<87ehydhnwk.fsf@fox.patthoyts.tk>
In-Reply-To
<87cab38f99075f149a9abe7caf4ec139a0a48213.1318580310.git.bert.wesarg@googlemail.com>
Bert Wesarg <bert.wesarg@googlemail.com> writes:
Show 24 quoted lines
>The current path for what we see the diff is not in the list of selected
>paths. But when we add single paths (with Ctrl) to the set the current path
>would not be used when the action is performed.
>
>Fix this by explicitly putting the path into the list before we start
>showing the diff.
>
>Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
>---
> git-gui.sh |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/git-gui.sh b/git-gui.sh
>index f897160..e5dd8bc 100755
>--- a/git-gui.sh
>+++ b/git-gui.sh
>@@ -2474,6 +2474,7 @@ proc toggle_or_diff {w x y} {
> 				[concat $after [list ui_ready]]
> 		}
> 	} else {
>+		set selected_paths($path) 1
> 		show_diff $path $w $lno
> 	}
> }

It is not clear what I should be looking for to test this. Can you re-write the commit message to be more clear about what you are fixing. Is this multiple unstaged files in the staging box? If so I don't see what path display is changing.

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD
Previous: Bert WesargNext: Bert Wesarg
Message 2 of 6 in “git-gui: fix multi selected file operation”
  1. git-gui: fix multi selected file operationBert Wesarg, Oct 14, 2011
  2. Pat ThoytsOct 15, 2011
  3. Bert WesargOct 17, 2011
  4. Pat ThoytsOct 17, 2011
  5. Bert WesargOct 18, 2011
  6. Pat ThoytsOct 18, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.