Re: [PATCH] test-lib.sh: unfilter GIT_PERF_*

From: Thomas Rast <trast@student.ethz.ch>
Date: Jan 15, 2013, 13:43 UTC
Message-ID: <87ehhmr28g.fsf@pctrast.inf.ethz.ch>
In-Reply-To: <1358254409-15187-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

> These variables are user parameters to control how to run the perf
> tests. Allow users to do so.

[...]

Show 8 quoted lines

> @@ -86,6 +86,9 @@ unset VISUAL EMAIL LANGUAGE COLUMNS $("$PERL_PATH" -e '
>  		PROVE
>  		VALGRIND
>  		PERF_AGGREGATING_LATER
> +		PERF_LARGE_REPO
> +		PERF_REPEAT_COUNT
> +		PERF_REPO
>  	));

Wouldn't it be more futureproof to put simply PERF as an entry, and rely on the leading-match logic

> 	my @vars = grep(/^GIT_/ && !/^GIT_($ok)/o, @env);

to allow all GIT_PERF variables?

Other than that, Ack. I never noticed because I set mine through config.mak, which goes to GIT-BUILD-OPTIONS. Those options are not exported, which means perl does not pick them up. (That just took me far too long to realize.)

-- 
Thomas Rast
trast@{inf,student}.ethz.ch