Re: submodule update and core.askpass

From: Thomas Rast <tr@thomasrast.ch>
Date: Nov 16, 2013, 21:42 UTC
Message-ID: <87eh6gkoq9.fsf@linux-k42r.v.cablecom.net>
In-Reply-To: <m28uwoxcoh.fsf@nds-macbook-air.labs.intellij.net>

+cc Daniel and Jens

Dmitry Neverov <dmitry.neverov@jetbrains.com> writes:

Show 11 quoted lines

> git -c core.askpass=pass.sh clone main-repo
> cd main-repo
> git submodule init
> git submodule sync
> git -c core.askpass=pass.sh submodule update
>
> The last command asks for a password interactively. 
>
> I've run bisect, it seems like it started failing from commit
> be8779f7ac9a3be9aa783df008d59082f4054f67. I've checked: submodule update
> works fine in 1.8.5.rc2 with removed call to clear_local_git_env.

Aside from GIT_CONFIG_PARAMETERS, which this needs, I wonder if we should also let other variables pass through. For example, if the user went out of their way to set GIT_ALTERNATE_OBJECT_DIRECTORIES, shouldn't we also respect that?

The list of variables that is unset by clear_local_git_env is $(git rev-parse --local-env-vars), currently

  GIT_ALTERNATE_OBJECT_DIRECTORIES
  GIT_CONFIG
  GIT_CONFIG_PARAMETERS
  GIT_OBJECT_DIRECTORY
  GIT_DIR
  GIT_WORK_TREE
  GIT_IMPLICIT_WORK_TREE
  GIT_GRAFT_FILE
  GIT_INDEX_FILE
  GIT_NO_REPLACE_OBJECTS
  GIT_PREFIX

-- 
Thomas Rast
tr@thomasrast.ch