Re: [PATCH] string_list: use string-list API in unsorted_string_list_lookup()

From: Ralf Thielow <ralf.thielow@gmail.com>
Date: Apr 25, 2016, 17:35 UTC
Message-ID: <87eg9t8uc2.fsf@gmail.com>
In-Reply-To: <alpine.DEB.2.20.1604240901570.2896@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 14 quoted lines

>>  
>> -	for (i = 0; i < list->nr; i++)
>> -		if (!cmp(string, list->items[i].string))
>> -			return list->items + i;
>> +	for_each_string_list_item(item, list) {
>> +		if (!cmp(string, item->string))
>> +			return item;
>> +	}
>>  	return NULL;
>
> If you drop the extra curly braces (thereby matching Git's coding style as
> an additional bonus), at least the patch won't increase the number of
> lines.
>

Oops. I'll send a new version of the patch without these extra curly braces.

Thanks!

> In any case, I like the simplification of the code.
>
> Ciao,
> Dscho