Re: Subtree Split Includes Commits Outside Prefix Directory

From: David A. Greene <greened@obbligato.org>
Date: May 21, 2016, 23:06 UTC
Message-ID: <87eg8vovsj.fsf@waller.obbligato.org>
In-Reply-To: <CAKU2X8bAXmVfJz9P7d3k-_d12sjyrzWt+kJCGj8V6fTDAjsFog@mail.gmail.com>

ELI <eliptus@gmail.com> writes:

Show 7 quoted lines

> I then reviewed the commit history of contrib/subtree/git-subtree.sh
> and determined that the last successful subtree push was performed
> prior to the integration of this change:
> https://git.kernel.org/cgit/git/git.git/commit/contrib/subtree/git-subtree.sh?id=933cfeb90b5d03b4096db6d60494a6eedea25d03
>
> As a next step, I reversed that patch on my local install of git
> subtree, and the result was a successful subtree push.

So you're saying that this patch caused a regression?

> Unfortunately, I have not yet reproduced this with a test main project
> and subprojects, and I cannot make the project I observed it in
> public.

I very much want to see a testcase for this. I'm planning to fundamentally rewrite the split code this year and want to make sure it covers everything it does now and fixes a few bugs that have been exposed lately.

It's tough to revert that patch since it fixed a problem for someone and we don't have a testcase demonstrating the problem you encountered. Not saying your problem isn't important but we need to understand it and have a way to flag it before fixing or hiding it with a revert of the above patch.

                       -David