git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] gitk: Fix the geometry when restoring from zoomed state

From
Pat Thoyts <patthoyts@users.sourceforge.net>
Date
Sep 18, 2009, 13:24 UTC
Message-ID
<87d45obd36.fsf@users.sourceforge.net>
In-Reply-To
<19122.10359.725107.949551@cargo.ozlabs.ibm.com>
Paul Mackerras <paulus@samba.org> writes:
Show 10 quoted lines
>Pat Thoyts writes:
>
>> The patch to handle the geometry of a restored gitk by Alexy Borzenkov
>> causes the position of the columns to creep each time the application
>> is restarted.  This patch addresses this by remembering the application
>> geometry for the normal state and saving that regardless of the actual
>> state when the application is closed.
>
>So this patch replaces Alexey's patch, then?  The context in your patch
>doesn't match the changes made in Alexey's patch AFAICS.
Correct. I posted a response to Alexy's patch saying I'd post an
alternative as I had trouble with the columns resizing and creeping
due to the assertion of 'wm state normal' during the settings save
each time.
See
 http://thread.gmane.org/gmane.comp.version-control.git/128026/focus=128652
The context of mine should be the gitk repository master (was
c21398be).
-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD
Previous: Alexey BorzenkovNext: Pat Thoyts
Message 11 of 16 in “gitk: restore wm state to normal before saving geometry information”
  1. gitk: restore wm state to normal before saving geometry informationAlexey Borzenkov, Sep 8, 2009
  2. 1/2 Work around leftover temporary save file.Pat Thoyts, Sep 15, 2009
  3. Alex RiesenSep 15, 2009
  4. Alexey BorzenkovSep 15, 2009
  5. Pat ThoytsSep 15, 2009
  6. Pat ThoytsSep 15, 2009
  7. 2/2 Fix the geometry when restoring from zoomed state.Pat Thoyts, Sep 15, 2009
  8. Alexey BorzenkovSep 15, 2009
  9. Paul MackerrasSep 17, 2009
  10. Alexey BorzenkovSep 17, 2009
  11. Pat ThoytsSep 18, 2009
  12. Pat ThoytsSep 15, 2009
  13. Alexey BorzenkovSep 15, 2009
  14. Alexey BorzenkovSep 15, 2009
  15. Paul MackerrasSep 16, 2009
  16. Pat ThoytsSep 16, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.