Re: [PATCH 1/3] Refactor working tree setup

From: Miles Bader <miles@gnu.org>
Date: Nov 8, 2007, 22:41 UTC
Message-ID: <87bqa4gy2h.fsf@catnip.gol.com>
In-Reply-To: <1194088993-25692-1-git-send-email-mh@glandium.org>

Mike Hommey <mh@glandium.org> writes:

> Create a setup_work_tree() that can be used from any command requiring
> a working tree conditionally.

...

> +void setup_work_tree(void) {
> +	const char *work_tree = get_git_work_tree();

Hi, could you please not use this "function begin brace at EOL" style?

It's inconsistent with the rest of the source, makes the code harder to read, and confuses Emacs in some cases[1]. Also it's an abomination unto God, but I imagine it's the first of these reasons that you'll care about the most... :-)

Thanks,

-Miles

[1] Until quite recently, Emacs c-mode couldn't find the beginning of such functions (recent versions of c-mode seem OK though).

-- 
The secret to creativity is knowing how to hide your sources.
  --Albert Einstein