Re: [PATCH] fix git-gui crash due to uninitialized variable
- From
Pat Thoyts <patthoyts@users.sourceforge.net>
- Date
- Jan 22, 2012, 23:18 UTC
- Message-ID
- <87bopvz5p9.fsf@fox.patthoyts.tk>
- In-Reply-To
- <20120121175724.GA7319@ecki>
Clemens Buchacher <drizzd@aon.at> writes:
Show 26 quoted lines
>Recently, a clone initiated via git gui on Windows crashed on me due to
>an "unknown variable cdone". It turns out that there is a code path
>where this variable is used uninitialized.
>
>Signed-off-by: Clemens Buchacher <drizzd@aon.at>
>---
>
>Looking at the output of display(), it's not clear to me now the
>function below could ever be called with total=0. But I can't delve into
>it more deeply right now, and this seems like an obvious fix.
>
> git-gui/lib/status_bar.tcl | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/git-gui/lib/status_bar.tcl b/git-gui/lib/status_bar.tcl
>index 95cb449..02111a1 100644
>--- a/git-gui/lib/status_bar.tcl
>+++ b/git-gui/lib/status_bar.tcl
>@@ -77,6 +77,7 @@ method start {msg uds} {
>
> method update {have total} {
> set pdone 0
>+ set cdone 0
> if {$total > 0} {
> set pdone [expr {100 * $have / $total}]
> set cdone [expr {[winfo width $w_c] * $have / $total}]It might be nice to know what kind of conditions triggered this for you, but the patch is fine. Thanks, applied.
-- Pat Thoyts http://www.patthoyts.tk/ PGP fingerprint 2C 6E 98 07 2C 59 C8 97 10 CE 11 E6 04 E0 B9 DD