Re: [PATCH 03/13] contrib/subtree: Better Error Handling for add

From: Andreas Schwab <schwab@linux-m68k.org>
Date: Aug 2, 2013, 08:19 UTC
Message-ID: <87bo5g5wu3.fsf@igel.home>
In-Reply-To: <1360064219-28789-4-git-send-email-greened@obbligato.org>

"David A. Greene" <greened@obbligato.org> writes:

>  	elif [ $# -eq 2 ]; then
> -		"cmd_add_repository" "$@"
> +	    git rev-parse -q --verify "$2^{commit}" >/dev/null ||
> +	    die "'$2' does not refer to a commit"

That doesn't make any sense. $2 is a commit in a remote repository which hasn't been fetched yet, so it can never be verified against the local repository.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.