Re: [PATCH 5/5] tree-walk: support :(attr) matching

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Nov 18, 2018, 19:58 UTC
Message-ID: <87bm6m17kt.fsf@evledraar.gmail.com>
In-Reply-To: <20181118164800.32759-6-pclouds@gmail.com>

On Sun, Nov 18 2018, Nguyễn Thái Ngọc Duy wrote:

As noted in https://public-inbox.org/git/87d0r217vr.fsf@evledraar.gmail.com/ I'm happy to see this implemented. I have not read this patch in much detail...

Show 16 quoted lines

> [...]
>  Documentation/glossary-content.txt |  2 +
> [...]
> diff --git a/Documentation/glossary-content.txt b/Documentation/glossary-content.txt
> index 0d2aa48c63..023ca95e7c 100644
> --- a/Documentation/glossary-content.txt
> +++ b/Documentation/glossary-content.txt
> @@ -404,6 +404,8 @@ these forms:
>  - "`!ATTR`" requires that the attribute `ATTR` be
>    unspecified.
>  +
> +Note that when matching against a tree object, attributes are still
> +obtained from working tree, not from the given tree object.
>
>  exclude;;
>  	After a path matches any non-exclude pathspec, it will be run

Just a poke again about what I brought up in the thread you replied to in https://public-inbox.org/git/CACsJy8CLHQ0mKhKXvTDAqy9TLwEFBSvHEu5UbPxHX4is2mK+Cg@mail.gmail.com/

I.e. the documentation of these various wildmatch() / attributes patterns we support is all over the place. Some in gitignore(5), some not documented at all, and some in gitglossary(7) (which really should not be serving as primary documentation for anything).