git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] parsecvs: produce tagger fields acceptable to newer git versions

From
Jim Meyering <jim@meyering.net>
Date
Jan 19, 2009, 12:44 UTC
Message-ID
<87ab9nbh49.fsf@meyering.net>
In-Reply-To
<20090119120217.GD4390@xi.wantstofly.org>
Lennert Buytenhek <buytenh@wantstofly.org> wrote:
Show 22 quoted lines
> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
>
> diff --git a/git.c b/git.c
> index da320d1..8f94d1b 100644
> --- a/git.c
> +++ b/git.c
> @@ -371,11 +371,13 @@ git_mktag (rev_commit *commit, char *name)
>  		"object %s\n"
>  		"type commit\n"
>  		"tag %s\n"
> -		"tagger %s\n"
> +		"tagger %s <%s> %lu +0000\n"
>  		"\n",
>  		commit->sha1,
>  		name,
> -		author ? author->full : commit->author);
> +		author ? author->full : commit->author,
> +		author ? author->email : commit->author,
> +		commit->date);
>      if (rv < 1) {
>  	fprintf (stderr, "%s: %s\n", filename, strerror (errno));
>  	fclose (f);
Hi Lennert,
I posted the same patch a while back.
    http://markmail.org/message/cebh7suc7ejpayos

However, I never heard back. You'll also need the patch below, if you're building against a newer version of git.

>From 93bc277dff113f1133ef25b8bb985af80f1fbe0e Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering@redhat.com>
Date: Thu, 6 Nov 2008 11:35:09 +0100
Subject: [PATCH 2/2] * tree.c (init_tree): Adapt to new git_config API.
---
 tree.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tree.c b/tree.c
index a76f27c..e2a041c 100644
--- a/tree.c
+++ b/tree.c
@@ -177,7 +177,7 @@ rev_commit *create_tree(rev_commit *leader)

 void init_tree(int n)
 {
-	git_config(git_default_config);
+	git_config(git_default_config, NULL);
 	strip = n;
 }

--
1.6.1.331.g9c367
Previous: Lennert BuytenhekNext: Lennert Buytenhek
Message 2 of 3 in “parsecvs: produce tagger fields acceptable to newer git versions”
  1. parsecvs: produce tagger fields acceptable to newer git versionsLennert Buytenhek, Jan 19, 2009
  2. Jim MeyeringJan 19, 2009
  3. Lennert BuytenhekJan 19, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.