Re: git send-email --notmuch expr
- From
Jed Brown <jed@59a2.org>
- Date
- Nov 25, 2009, 13:06 UTC
- Message-ID
- <87aaya69eg.fsf@59A2.org>
- In-Reply-To
- <m3hbsic3l5.fsf@localhost.localdomain>
On Wed, 25 Nov 2009 02:16:52 -0800 (PST), Jakub Narebski <jnareb@gmail.com> wrote:
> (?: ... ) is in Perl non-capturing grouping
Thanks. Actually that code only executes under --compose, the headers provided by format-patch all just come through untouched (but all the interesting ones are duplicated). So it looks like we just need to actually parse the relevant headers from format-patch, before the part where the user gets prompted. These are a little harder because they can span multiple lines. The current validation with --compose is a bit broken: suppose the user sets the perfectly valid header
To: foo@example.com,
bar@example.comThe validation will strip the first line while issuing warning, but send the second through untouched.
Jed