Re: [PATCH/RFC] l10n: de.po: translate 39 new messages
- From
Thomas Rast <trast@inf.ethz.ch>
- Date
- Apr 17, 2013, 08:09 UTC
- Message-ID
- <87a9ox1sue.fsf@linux-k42r.v.cablecom.net>
- In-Reply-To
- <CAN0XMOLmwUpwOi0xz4iOy3wfhzCeeNKNgywgS9ZfaET172vsBQ@mail.gmail.com>
Ralf Thielow <ralf.thielow@gmail.com> writes:
Show 30 quoted lines
> Hi, > > Thanks for review! > > On Mon, Apr 15, 2013 at 9:26 PM, Christian Stimming <stimming@tuhh.de>wrote: > >> Thanks for the regular update! This is great work. >> >> One issue with the plural form messages, though: >> >> Am Montag, 15. April 2013, 18:27:40 schrieb Ralf Thielow: >> > #: bundle.c:186 >> > -#, fuzzy, c-format >> > +#, c-format >> > msgid "The bundle contains this ref:" >> > msgid_plural "The bundle contains these %d refs:" >> > -msgstr[0] "Das Paket enthält %d Referenz" >> > -msgstr[1] "Das Paket enthält %d Referenzen" >> > +msgstr[0] "Das Paket enthält diese Referenz:" >> > +msgstr[1] "Das Paket enthält diese %d Referenzen:" >> >> The msgstr[0] must still contain a %d conversion specifier (which will be >> filled with the number 1) even though the translated sentence wouldn't need >> the 1 anymore. The previous msgstr[0] was correct; the English singular >> msgid >> is not. >> > That made me wonder, too. I've played around a bit with this, and it seems > to be OK as long as one of those strings contain at least one format > specifier.
C printf() only knows about the number and types of arguments from the format string, so *ignoring* arguments is not a problem for correctness.
--
Thomas Rast
trast@{inf,student}.ethz.ch