Re: [PATCH] dir: avoid -Wdiscarded-qualifiers in remove_path()
- From
Collin Funk <collin.funk1@gmail.com>
- Date
- Mar 10, 2026, 00:22 UTC
- Message-ID
- <87a4wgwn18.fsf@gmail.com>
- In-Reply-To
- <xmqqbjgx6obs.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 17 quoted lines
> Collin Funk <collin.funk1@gmail.com> writes: > >> When building with glibc-2.43 there is the following warning: >> >> dir.c:3526:15: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] >> 3526 | slash = strrchr(name, '/'); >> | ^ >> >> In this case we use a non-const pointer to get the last slash of the >> unwritable file name, and then use it again to write in the strdup'd >> file name. >> >> We can avoid this warning and make the code a bit more clear by using a >> separate variable to access the original argument and it's strdup'd >> copy. > > "it's" -> "its", if I am reading the above correctly?
Yep, my mistake. Assuming you can fix that locally?
Thanks, Collin