git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 17:15 UTC

Re: [PATCH] dir: avoid -Wdiscarded-qualifiers in remove_path()

From
Collin Funk <collin.funk1@gmail.com>
Date
Mar 10, 2026, 00:22 UTC
Message-ID
<87a4wgwn18.fsf@gmail.com>
In-Reply-To
<xmqqbjgx6obs.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 17 quoted lines
> Collin Funk <collin.funk1@gmail.com> writes:
>
>> When building with glibc-2.43 there is the following warning:
>>
>>     dir.c:3526:15: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
>>      3526 |         slash = strrchr(name, '/');
>>           |               ^
>>
>> In this case we use a non-const pointer to get the last slash of the
>> unwritable file name, and then use it again to write in the strdup'd
>> file name.
>>
>> We can avoid this warning and make the code a bit more clear by using a
>> separate variable to access the original argument and it's strdup'd
>> copy.
>
> "it's" -> "its", if I am reading the above correctly?
Yep, my mistake. Assuming you can fix that locally?

Thanks, Collin

Previous: Junio C HamanoNext: Junio C Hamano
Message 3 of 4 in “dir: avoid -Wdiscarded-qualifiers in remove_path()”
  1. dir: avoid -Wdiscarded-qualifiers in remove_path()Collin Funk, Mar 9, 2026
  2. Junio C HamanoMar 9, 2026
  3. Collin FunkMar 10, 2026
  4. Junio C HamanoMar 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.