git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-diff: must --exit-code work with --ignore* options?

From
Jim Meyering <jim@meyering.net>
Date
May 23, 2009, 07:26 UTC
Message-ID
<878wkoe0v2.fsf@meyering.net>
In-Reply-To
<7v7i087twu.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
Show 25 quoted lines
> Jim Meyering <jim@meyering.net> writes:
>> Junio C Hamano wrote:
>>> Jim Meyering <jim@meyering.net> writes:
>>>>
>>>>     # do this in an empty directory
>>>>     $ git init -q; echo>k; git add .; git commit -q -m. .; echo \ >k
>>>>     $ git diff --ignore-space-at-eol --quiet || echo bad
>>>>     bad
>>>
>>> I am slightly torn about this, in that I can picture myself saying that
>>> this is unintuitive on some different days, but not today ;-)
>>
>> Thanks for the quick reply.  Here's why I noticed:
>> ...
>
> It seems that today is already "some different day" ;-) We could do
> something like this patch.
>
> While in the longer term I think it may make the world a better place by
> being more consistent with what users expect, I am not sure at what
> revision boundary we should introduce such a semantic change.
>
> -- >8 --
> Subject: [PATCH] diff --quiet: special case "ignore whitespace" options
> ...
Wow.  And now a patch.  Service with style ;-)
> We could always declare this a bug and apply the "fix" at any time.  It's
> all perception ;-).

The declare-it-a-bug option sounds sensible, since I doubt anyone even noticed, much less relied on, the changing behavior.

Thank you!
Previous: Junio C HamanoNext: Jim Meyering
Message 5 of 9 in “git-diff: must --exit-code work with --ignore* options?”
  1. Jim MeyeringMay 22, 2009
  2. Junio C HamanoMay 22, 2009
  3. Jim MeyeringMay 22, 2009
  4. Junio C HamanoMay 22, 2009
  5. Jim MeyeringMay 23, 2009
  6. Jim MeyeringAug 30, 2009
  7. Junio C HamanoAug 30, 2009
  8. Jim MeyeringAug 30, 2009
  9. Thell FowlerSep 8, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.