git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-gui: change the termination checks to avoid potential hang.

From
Pat Thoyts <patthoyts@users.sourceforge.net>
Date
Aug 18, 2010, 22:48 UTC
Message-ID
<878w431qry.fsf@fox.patthoyts.tk>
In-Reply-To
<20100818042107.GC21185@burratino>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 15 quoted lines
>
>And consistently.
>
> $ wish
> % puts $tcl_version
> 8.5
> % puts $tk_version
> 8.5
> $ dpkg -l tcl8.5 tk8.5 | tail -2
> ii  tcl8.5         8.5.8-2       Tcl (the Tool Command Language) v8.5 - ru
> ii  tk8.5          8.5.8-1       Tk toolkit for Tcl and X11, v8.5 - run-ti
> $ ./git-gui--askpass
> <types passphrase>
>
>The window would stay open and hang.

OK I managed to confirm that using Tk 8.5. It seems 8.4 and 8.6 get away with it. I've pushed the fix to git-gui master now. Thanks for testing.

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD
Previous: Jonathan NiederNext: Pat Thoyts
Message 5 of 6 in “git-gui--askpass: Do not hang on exit”
  1. git-gui--askpass: Do not hang on exitJonathan Nieder, Jul 4, 2010
  2. git-gui--askpass: Do not hang on exitJonathan Nieder, Jul 4, 2010
  3. git-gui: change the termination checks to avoid potential hang.Pat Thoyts, Aug 14, 2010
  4. Jonathan NiederAug 18, 2010
  5. Pat ThoytsAug 18, 2010
  6. Pat ThoytsAug 15, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.