git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t9001: avoid not portable '\n' with sed

From
David Kastrup <dak@gnu.org>
Date
Jun 4, 2014, 18:47 UTC
Message-ID
<878upc7bre.fsf@fencepost.gnu.org>
In-Reply-To
<xmqqr434vaeh.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 18 quoted lines
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> t9001 used a '\n' in a sed expression to split one line into two lines.
>> Some versions of sed simply ignore the '\' before the 'n', treating
>> '\n' as 'n'.
>>
>> As the test already requires perl as a prerequisite, use perl instead of sed.
>>
>> Signed-off-by: Torsten Bögershausen <tboegi@web.de>
>> ---
>
> Hmph.  I read this in pubs.opengroup.org/onlinepubs/9699919799/utilities/sed.html
>
>     The escape sequence '\n' shall match a <newline> embedded in the
>     pattern space.
>
> so it may be better to be a bit more explicit in the log message to
> say whose implementation has this issue to warn people.
"shall match" talks about the match expression, not the replacement.
-- 
David Kastrup
Previous: Andreas Schwab
Message 8 of 8 in “t9001: avoid not portable '\n' with sed”
  1. t9001: avoid not portable '\n' with sedTorsten Bögershausen, Jun 4, 2014
  2. Junio C HamanoJun 4, 2014
  3. Junio C HamanoJun 4, 2014
  4. Torsten BögershausenJun 4, 2014
  5. John KeepingJun 4, 2014
  6. Junio C HamanoJun 4, 2014
  7. Andreas SchwabJun 4, 2014
  8. David KastrupJun 4, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.