Re: [PATCH v2 14/14] git-cvsexportcommit: port to SHA-256

From: Andreas Schwab <schwab@linux-m68k.org>
Date: Aug 5, 2020, 17:29 UTC
Message-ID: <878setj922.fsf@igel.home>
In-Reply-To: <20200803235007.GN6540@camp.crustytoothpaste.net>

On Aug 03 2020, brian m. carlson wrote:

Show 20 quoted lines

> On 2020-08-03 at 18:37:27, Andreas Schwab wrote:
>> On Jun 22 2020, brian m. carlson wrote:
>> 
>> > diff --git a/git-cvsexportcommit.perl b/git-cvsexportcommit.perl
>> > index fc00d5946a..6483d792d3 100755
>> > --- a/git-cvsexportcommit.perl
>> > +++ b/git-cvsexportcommit.perl
>> > @@ -22,6 +22,10 @@
>> >  my $repo = Git->repository();
>> >  $opt_w = $repo->config('cvsexportcommit.cvsdir') unless defined $opt_w;
>> >  
>> > +my $tmpdir = File::Temp->newdir;
>> 
>> File::Temp in perl 5.10 doesn't have the newdir method.
>
> That method was added in File::Temp 0.19, which was added in 2007.  Does
>
>   my $tmpdir = File::Temp::tempdir(CLEANUP => 1);
>
> do the right thing on your Perl 5.10?

With that change, the testsuite runs sucessfully.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."