Re: [PATCH v2 07/10] builtin/fsck: move reverse index verification into the packed source

From: Toon Claes <toon@iotcl.com>
Date: Sep 11, 2026, 11:14 UTC
Message-ID: <878q58nip1.fsf@emacs.iotcl.com>
In-Reply-To: <20260831-pks-odb-source-fsck-v2-7-f9b16ef4957b@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 7 quoted lines

> The checks for reverse indexes live in `check_pack_rev_indexes()`, which
> is hosted in "builtin/fsck.c". These checks are obviously specific to
> the "packed" backend.
>
> Move the logic into `odb_source_packed_fsck()`. As in the preceding
> commit, drop the dedicated `ERROR_PACK_REV_INDEX` bit and instead use
> the generic `ERROR_OBJECT` bit.

It wasn't immediately obvious to me, but the check is moved to odb_source_packed_fsck() which is the callback for `.fsck` which is called by odb_fsck() in odb/odb.c. In builtin/fsck.c a negative return value is converted to ERROR_OBJECT.

Because it's part of the ODB, that makes sense to me.

-- 
Laters,
Toon