Re: [PATCH] gitk: Handle msysGit version during version comparisons

From: Pat Thoyts <patthoyts@users.sourceforge.net>
Date: May 19, 2009, 10:38 UTC
Message-ID: <877i0ds7hr.fsf@users.sourceforge.net>
In-Reply-To: <4A127306.6040904@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

Show 21 quoted lines

>Johannes Schindelin venit, vidit, dixit 19.05.2009 10:43:
>> Hi,
>> 
>> On Mon, 18 May 2009, Pat Thoyts wrote:
>> 
>>>
>>>   msysGit generates version strings with text appended which cannot
>>>   be used with vcompare. Limit git_version to the first three digits
>>>   which are the real git version.
>>>
>>> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
>> 
>> Is that indent intentional?
>> 
>> Ciao,
>> Dscho
>
>It is clearly indentional :)
>
>[During my git beginnings, the standard output format of git log made me
>believe I should format commit message bodies like that, too.]

It was intentional and the above followup is why. Evidently I should not do so in the future.

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD