Re: [PATCH v6 00/16] daemon-win32

From: Pat Thoyts <patthoyts@users.sourceforge.net>
Date: Nov 3, 2010, 21:11 UTC
Message-ID: <877hgunmdc.fsf@fox.patthoyts.tk>
In-Reply-To: <1288801894-1168-1-git-send-email-kusmabite@gmail.com>

Erik Faye-Lund <kusmabite@gmail.com> writes:

>Here's hopefully the last iteration of this series. The previous version
>only got a single complain about a typo in the subject of patch 14/15, so
>it seems like most controversies have been settled.

I pulled this win32-daemon branch into my msysgit build tree and built it. I get the following warnings:

    CC daemon.o
daemon.c: In function 'service_loop':
daemon.c:674: warning: dereferencing pointer 'ss.124' does break strict-aliasing rules
daemon.c:676: warning: dereferencing pointer 'ss.124' does break strict-aliasing rules
daemon.c:681: warning: dereferencing pointer 'ss.124' does break strict-aliasing rules
daemon.c:919: note: initialized from here
daemon.c:679: warning: dereferencing pointer 'sin_addr' does break strict-aliasing rules
daemon.c:675: note: initialized from here
daemon.c:691: warning: dereferencing pointer 'sin6_addr' does break strict-aliasing rules
daemon.c:682: note: initialized from here

Otherwise it builds clean. The daemon running on Windows7 seems to be working fine for both ipv4 and ipv6 connections (I tried both).

However, monitoring the resource usage in procexp it looks like there is a handle leak. Each 'git ls-remote' over ipv6 is gaining 16 handles that do not appear to be released. They're all process handles for dead processes it looks like, so possibly there is a missing waitpid() or something similar for the 'git daemon -serve' subprocess. Doing this over ipv4 leaks 2 handles per request.

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD