Re: [DOCBUG] git subtree synopsis needs updating

From: greened@obbligato.org <greened@obbligato.org>
Date: Jan 1, 2013, 02:51 UTC
Message-ID: <877gnx39aa.fsf@waller.obbligato.org>
In-Reply-To: <20121019152158.4297707b@chalon.bertin.fr>

Yann Dirson <dirson@bertin.fr> writes:

Show 11 quoted lines

> As the examples in git-subtree.txt show, the synopsis in the same file should
> surely get a patch along the lines of:
>
> -'git subtree' add   -P <prefix> <commit>
> +'git subtree' add   -P <prefix> <repository> <commit>
>
> Failure to specify the repository (by just specifying a local commit) fails with
> the cryptic:
>
>  warning: read-tree: emptying the index with no arguments is deprecated; use --empty
>  fatal: just how do you expect me to merge 0 trees?

Specifying a local branch works fine, though, as does a raw commit hash. What do you mean by "local commit?"

I have updated the documentation and will submit it tonight or tomorrow.

Any invalid refspec should be caught early and a more useful message will be displayed.

> Furthermore, the doc paragraph for add, aside from mentionning <repository>, also
> mentions a <refspec> which the synopsis does not show either.

Fixed.

> As a sidenote it someone wants to do some maintainance, using "." as repository when
> the branch to subtree-add is already locally available does not work well either
> (fails with "could not find ref myremote/myhead").

Seems to work for me. Can you give me the command you're using when you see the problem?

Thanks for the report!

                          -David