Re: [PATCH 1/2] git-reset.txt: render tables correctly under Asciidoctor

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Nov 28, 2018, 19:44 UTC
Message-ID: <877egxyojp.fsf@evledraar.gmail.com>
In-Reply-To: <1596a9ff9fa6849f53590de1b15eb18ee6b41e4d.1543429054.git.martin.agren@gmail.com>

On Wed, Nov 28 2018, Martin Ågren wrote:

Show 15 quoted lines

> Asciidoctor removes the indentation of each line in these tables, so the
> last lines of each table have a completely broken alignment.
>
> Similar to 379805051d ("Documentation: render revisions correctly under
> Asciidoctor", 2018-05-06), use an explicit literal block to indicate
> that we want to keep the leading whitespace in the tables.
>
> Because this gives us some extra indentation, we can remove the one that
> we have been carrying explicitly. That is, drop the first six spaces of
> indentation on each line. With Asciidoc (8.6.10), this results in
> identical rendering before and after this commit, both for git-reset.1
> and git-reset.html.
>
> Reported-by: Paweł Samoraj <samoraj.pawel@gmail.com>
> Signed-off-by: Martin Ågren <martin.agren@gmail.com>

Earlier I was trying to get the Documentation/doc-diff script to diff the asciidoc and asciidoctor docs without much success (hadn't used it before, just hacking the Makefile to turn on asciidoctor yielded syntax errors or something).

Is something like that a thing we could make into a regression test?