Re: [PATCH 2/5] cat-file: mention --unordered along with --batch-all-objects
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Oct 5, 2021, 21:02 UTC
- Message-ID
- <877derjia9.fsf@evledraar.gmail.com>
- In-Reply-To
- <YVy2DNd+XemykKE0@coredump.intra.peff.net>
On Tue, Oct 05 2021, Jeff King wrote:
Show 29 quoted lines
> The note on ordering for --batch-all-objects was written when that was > the only possible ordering. These days we have --unordered, too, so > let's point to it. > > Signed-off-by: Jeff King <peff@peff.net> > --- > Not strictly related to this series, but I noticed it while I was in the > area, and I'm about to touch these same lines, so it seemed better than > spinning it off into its own series. > > Documentation/git-cat-file.txt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/git-cat-file.txt b/Documentation/git-cat-file.txt > index 4eb0421b3f..6467707c6e 100644 > --- a/Documentation/git-cat-file.txt > +++ b/Documentation/git-cat-file.txt > @@ -94,8 +94,9 @@ OPTIONS > Instead of reading a list of objects on stdin, perform the > requested batch operation on all objects in the repository and > any alternate object stores (not just reachable objects). > - Requires `--batch` or `--batch-check` be specified. Note that > - the objects are visited in order sorted by their hashes. > + Requires `--batch` or `--batch-check` be specified. By default, > + the objects are visited in order sorted by their hashes; see > + also `--unordered` below. > > --buffer:: > Normally batch output is flushed after each object is output, so
Since you're doing while-you're-at-it anyway: Isn't the --unordered documentation also incorrect to reference --batch, which I take as it lazily using as a shorthand for --batch-all-objects.