git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Quote the missing GIT_DIR.

From
SBSanti Béjar <sbejar@gmail.com>
Date
Oct 5, 2005, 16:58 UTC
Message-ID
<8764sbq4t9.fsf@gmail.com>
Signed-off-by: Santi Béjar <sbejar@gmail.com>
---
 git-commit.sh |    2 +-
 git-fetch.sh  |    6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

applies-to: f1aeb5e1caeb925ef1f7dc9993096556d10b49a9 9dbea220044374b801516e7d6b4ceb390c2cbd94

diff --git a/git-commit.sh b/git-commit.sh
--- a/git-commit.sh
+++ b/git-commit.sh
@@ -198,7 +198,7 @@ else
 	PARENTS=""
 fi
 git-status >>"$GIT_DIR"/.editmsg
-if [ "$?" != "0" -a ! -f $GIT_DIR/MERGE_HEAD ]
+if [ "$?" != "0" -a ! -f "$GIT_DIR/MERGE_HEAD" ]
 then
 	rm -f "$GIT_DIR"/.editmsg
 	git-status
diff --git a/git-fetch.sh b/git-fetch.sh
--- a/git-fetch.sh
+++ b/git-fetch.sh
@@ -49,7 +49,7 @@ rsync_slurped_objects=
 
 if test "" = "$append"
 then
-	: >$GIT_DIR/FETCH_HEAD
+	: >"$GIT_DIR/FETCH_HEAD"
 fi
 
 append_fetch_head () {
@@ -86,11 +86,11 @@ append_fetch_head () {
     if git-cat-file commit "$head_" >/dev/null 2>&1
     then
 	headc_=$(git-rev-parse --verify "$head_^0") || exit
-	echo "$headc_	$not_for_merge_	$note_" >>$GIT_DIR/FETCH_HEAD
+	echo "$headc_	$not_for_merge_	$note_" >>"$GIT_DIR/FETCH_HEAD"
 	echo >&2 "* committish: $head_"
 	echo >&2 "  $note_"
     else
-	echo "$head_	not-for-merge	$note_" >>$GIT_DIR/FETCH_HEAD
+	echo "$head_	not-for-merge	$note_" >>"$GIT_DIR/FETCH_HEAD"
 	echo >&2 "* non-commit: $head_"
 	echo >&2 "  $note_"
     fi
---
0.99.8.GIT
Message 1 of 1 in “Quote the missing GIT_DIR.”
  1. Quote the missing GIT_DIR.Santi Béjar, Oct 5, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.