Re: [git-svn PATCH] Add --no-rebase option to git-svn dcommit

From: David Kågedal <davidk@lysator.liu.se>
Date: May 3, 2007, 06:48 UTC
Message-ID: <87647aqu6i.fsf@morpheus.local>
In-Reply-To: <20070503054749.20115.53805.stgit@yoghurt>

Karl Hasselström <kha@treskal.com> writes:

Show 14 quoted lines

> git-svn dcommit exports commits to Subversion, then imports them back
> to git again, and last but not least rebases or resets HEAD to the
> last of the new commits. I guess this rebasing is convenient when
> using just git, but when the commits to be exported are managed by
> StGIT, it's really annoying. So add an option to disable this
> behavior. And document it, too!
>
> Signed-off-by: Karl Hasselström <kha@treskal.com>
> ---
>
> Arguably, the switch should be --rebase instead, and default to not
> rebase. But that would change the existing behavior, and possibly make
> dcommit less convenient to use for at least the person who implemented
> the existing behavior. Opinions?

I don't agree. The rebase behaviour makes perfect sense in the normal case, and I've been using it without problems. The special case is when you start using stgit, so that's when you need to tell dcommit to do something out of the ordinary.

Other than that, I like your patch.  But you knew that already :-)

-- 
David Kågedal