Re: [PATCH] git-add: allow --ignore-missing always, not just in dry run

From: Thomas Rast <trast@student.ethz.ch>
Date: Jan 19, 2012, 11:03 UTC
Message-ID: <8762g87y4q.fsf@thomas.inf.ethz.ch>
In-Reply-To: <7vobu0liwj.fsf@alter.siamese.dyndns.org>

[dropped Dieter as this really goes off on an internal tangent]

Junio C Hamano <gitster@pobox.com> writes:

> If somebody is writing a script using "git add" (which is not recommended
> to begin with)

Can we still stick to that stance? Our tests are increasingly using 'git add' instead of 'git update-index --add':

  $ git grep 'git[ -]add' t/ | wc -l
  1540
  $ git grep 'git[ -]update-index --add' t/ | wc -l
  269
  $ git grep 'git[ -]update-index --add' v1.6.0 t/ | wc -l
  251
  $ git grep 'git[ -]add' v1.6.0 t/ | wc -l
  705

So while git(1) still says git-add is porcelain (and thus not to be used for scripting), it has mostly superseded 'git update-index --add' in new script usage even within git.git. I suspect the same goes for things like git-rm, git-commit, etc.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch