git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/5] git-gui i18n: mark strings for translation

From
Pat Thoyts <patthoyts@users.sourceforge.net>
Date
Oct 3, 2016, 10:30 UTC
Message-ID
<8760p9wwr3.fsf@red.patthoyts.tk>
In-Reply-To
<1462704778-4722-1-git-send-email-vascomalmeida@sapo.pt>
Vasco Almeida <vascomalmeida@sapo.pt> writes:
Show 42 quoted lines
>Mark strings for translation in lib/index.tcl that were seemingly
>left behind by 700e560 ("git-gui: Mark forgotten strings for
>translation.", 2008-09-04) which marks string in do_revert_selection
>procedure.
>These strings are passed to unstage_help and add_helper procedures.
>
>Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>
>---
> lib/index.tcl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/lib/index.tcl b/lib/index.tcl
>index 74a81a7..3a3e534 100644
>--- a/lib/index.tcl
>+++ b/lib/index.tcl
>@@ -291,7 +291,7 @@ proc do_unstage_selection {} {
> 
> 	if {[array size selected_paths] > 0} {
> 		unstage_helper \
>-			{Unstaging selected files from commit} \
>+			[mc "Unstaging selected files from commit"] \
> 			[array names selected_paths]
> 	} elseif {$current_diff_path ne {}} {
> 		unstage_helper \
>@@ -343,7 +343,7 @@ proc do_add_selection {} {
> 
> 	if {[array size selected_paths] > 0} {
> 		add_helper \
>-			{Adding selected files} \
>+			[mc "Adding selected files"] \
> 			[array names selected_paths]
> 	} elseif {$current_diff_path ne {}} {
> 		add_helper \
>@@ -385,7 +385,7 @@ proc do_add_all {} {
> 			set paths [concat $paths $untracked_paths]
> 		}
> 	}
>-	add_helper {Adding all changed files} $paths
>+	add_helper [mc "Adding all changed files"] $paths
> }
> 
> proc revert_helper {txt paths} {

This series looks good. Especially noticing the misuse of the append command. Applied to my pu for now. Thank you,

-- 
Pat Thoyts                            http://www.patthoyts.tk/
PGP fingerprint 2C 6E 98 07 2C 59 C8 97  10 CE 11 E6 04 E0 B9 DD
Previous: Vasco AlmeidaNext: Vasco Almeida
Message 7 of 8 in “git-gui i18n: mark strings for translation”
  1. 1/5 git-gui i18n: mark strings for translationVasco Almeida, May 8, 2016
  2. 2/5 git-gui i18n: internationalize use of colon punctuationVasco Almeida, May 8, 2016
  3. 3/5 git-gui i18n: mark "usage:" strings for translationVasco Almeida, May 8, 2016
  4. 4/5 git-gui: fix incorrect use of Tcl append commandVasco Almeida, May 8, 2016
  5. Pat ThoytsOct 3, 2016
  6. 5/5 git-gui i18n: mark string in lib/error.tcl for translationVasco Almeida, May 8, 2016
  7. Pat ThoytsOct 3, 2016
  8. Vasco AlmeidaOct 3, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.