Re: Make git-replay(1) warn if revision-range isn't a range (was: Re: [PATCH v2] replay: support replaying down from root commit)
- From
Toon Claes <toon@iotcl.com>
- Date
- Mar 25, 2026, 15:35 UTC
- Message-ID
- <875x6j2a7v.fsf@iotcl.com>
- In-Reply-To
- <E0A14573-BBE2-4ADF-989C-E5B2A7E3E166@gmail.com>
Ben Knoble <ben.knoble@gmail.com> writes:
Show 17 quoted lines
>> The patch looks good to me, but I wonder if the docs should be updated >> somehow, especially to try to avoid confusion in case users don't >> properly specify a range. >> >> For example, before this, `git replay --onto main topic` would fail, >> but emit "fatal: replaying down from root commit is not supported >> yet!". This would likely help users understand that they might need to >> properly specify a range like "main..topic" instead of 'topic". >> >> Now it would likely fail without any error message. > > Having used replay in a large monorepo where I juggle many branches > (so rebasing another in-flight topic without otherwise interrupting my > work is valuable), I’ve made this mistake a few times. Some way of > handling it more gracefully would be appreciated: perhaps the root > case is rare enough to warrant an option or confirmation prompt (when > attached interactively)?
Yeah, there is definetily room for improvement here. But I consider that outside the scope of this series and more like #leftoverbits.
-- Cheers, Toon