Re: [PATCH] git.el: Support for incremental status updates.
Karl Hasselström <kha@treskal.com> writes:
Show 6 quoted lines
> git.el already requires ewoc. And it uses a number of ewoc functions
> (and has done so since its creation); this newly introduced call is
> the only one that fails.
>
> Also, I've just discovered that with Emacs 22.1, I don't see this
> problem. So my guess is that ewoc-set-data is newer than Emacs 21.4.
Yes, it's a new function. Something like this should work:
From 8da6b3257fe785484c5683fc97edccf75ac5588d Mon Sep 17 00:00:00 2001
From: Alexandre Julliard <julliard@winehq.org>
Date: Tue, 31 Jul 2007 20:45:53 +0200
Subject: [PATCH] git.el: Avoid using ewoc-set-data for compatibility with Emacs 21.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
---
contrib/emacs/git.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/emacs/git.el b/contrib/emacs/git.el
index 9bcd7c4..f6102fc 100644
--- a/contrib/emacs/git.el
+++ b/contrib/emacs/git.el
@@ -530,7 +530,7 @@ and returns the process output as a string."
(setf (git-fileinfo->needs-refresh info) t)
(when node ;preserve the marked flag
(setf (git-fileinfo->marked info) (git-fileinfo->marked (ewoc-data node))))
- (if node (ewoc-set-data node info) (ewoc-enter-last status info))))
+ (if node (setf (ewoc-data node) info) (ewoc-enter-last status info))))
(defun git-run-diff-index (status files)
"Run git-diff-index on FILES and parse the results into STATUS.
--
1.5.3.rc3.97.gcb90c
--
Alexandre Julliard
julliard@winehq.org