Re: [PATCH v2 1/7] remote-curl: pass "struct strvec *" instead of int/char ** pair

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Sep 13, 2021, 03:56 UTC
Message-ID: <874kap5dqp.fsf@evledraar.gmail.com>
In-Reply-To: <CAPUEspizWWigu4yb_fK1kmzJDx7G0JUOFmRsAfaKeuvTPrk4bA@mail.gmail.com>

On Sat, Sep 11 2021, Carlo Arenas wrote:

Show 6 quoted lines

> On Sat, Sep 11, 2021 at 5:16 PM Ævar Arnfjörð Bjarmason
> <avarab@gmail.com> wrote:
>>
>> We'll be changing the "int nr" in the "struct strvec" to "int size_t"
>
> Did you mean "size_t nr"?

Yes, will fix.

Show 8 quoted lines

>> -static int push_git(struct discovery *heads, int nr_spec, const char **specs)
>> +static int push_git(struct discovery *heads, struct strvec *specs)
>>  {
>>         struct rpc_state rpc;
>> -       int i, err;
>> +       int i;
>
> you are already splitting them, why not then change 'i' also to be a size_t?

The conversion to size_t comes later in this series, this is setting that diff up to be smaller. I.e. we'll then to s/int i/size_t /g.