Re: [PATCH v5 6/6] RFC blame: use a fingerprint heuristic to match ignored lines

From: David Kastrup <dak@gnu.org>
Date: Apr 7, 2019, 21:52 UTC
Message-ID: <8736mtqy9n.fsf@fencepost.gnu.org>
In-Reply-To: <20190407214635.12984-1-michael@platin.gs>

michael@platin.gs writes:

Show 9 quoted lines

> From: Michael Platings <michael@platin.gs>
>
> Hi Barret,
> This is the updated fuzzy matching algorithm, sorry for the delay. It does
> highlight a bug in the calculation for the number of lines ("int nr_parent_lines
>  = e->num_lines - delta;") - if you apply the patch, build it, then try to
> ./git blame --ignore-rev <the patch commit ID> blame.c then you'll get a segfault
> because nr_parent_lines is a negative number. I haven't had time to investigate further
> but I have confirmed that the bug is not due to my patch.

If you segfault with the patch and don't segfault with the patch, there is not much of a point in declaring this "somebody else's problem", is there? It has to be fixed anyway in order to make the patch get in.

Or am I fundamentally misunderstanding something here?

-- 
David Kastrup