Re: Questions about trailer configuration semantics

From: Anders Waldenborg <anders@0x63.nu>
Date: Jul 27, 2020, 23:17 UTC
Message-ID: <87365cr1in.fsf@0x63.nu>
In-Reply-To: <xmqqa6zkfu3b.fsf@gitster.c.googlers.com>

Junio C Hamano writes:

> I had the same thought but then a question struck and stopped me:
> what should happen if "trailer.X.something" and
> "trailer.x.somethingelse" are both defined?

Good point.

If we follow the same reasoning as with what happens with prefix matching (config order matters) the one that happens to be mentioned first in configuration wins.

The same thing actually happens today with .key:

trailer.foo.key=Hello trailer.bar.key=HELLO

$ printf "\nHELLo: hi\n" | \
  git -c "trailer.foo.key=Hello" -c "trailer.bar.key=HELLO" interpret-trailers --parse
Hello: hi

but if we swap order of config:

$ printf "\nHELLo: hi\n" | \
  git -c "trailer.bar.key=HELLO" -c "trailer.foo.key=Hello" interpret-trailers --parse
HELLO: hi