Re: [PATCH 6/8] odb/source: support writing alternates when creating the database

From: Toon Claes <toon@iotcl.com>
Date: Aug 28, 2026, 14:53 UTC
Message-ID: <8733vyuwid.fsf@emacs.iotcl.com>
In-Reply-To: <20260825-pks-odb-write-alternates-at-creation-time-v1-6-911513ba95c3@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 20 quoted lines

> Add the ability to write alternates when creating the object database.
> This change allows us to remove the `write_alternates()` callback in a
> subsequent patch.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  odb/source-files.c | 73 ++++++++++++++++++++++++++++++++++++++++++++++++++++--
>  odb/source.h       | 18 +++++++++++---
>  setup.c            |  4 ++-
>  3 files changed, 89 insertions(+), 6 deletions(-)
>
> diff --git a/odb/source.h b/odb/source.h
> index ea8675247e..86b82fab3b 100644
> --- a/odb/source.h
> +++ b/odb/source.h
> @@ -5,6 +5,7 @@
>  #include "object.h"
>  #include "odb.h"
>  #include "odb/transaction.h"
> +#include "strvec.h"

I see `struct strvec;` is already defined below odb_source_type_to_name(). Can we not include this and put the new struct below the strvec definition?

-- 
Laters,
Toon