Re: [PATCH 6/7] git-blame.el: Doc fixes and cleanup

From: David Kågedal <davidk@lysator.liu.se>
Date: Feb 9, 2007, 11:02 UTC
Message-ID: <871wkzpp98.fsf@morpheus.local>
In-Reply-To: <eqhfdv$8uq$1@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> writes:

Show 15 quoted lines

> [Cc: git@vger.kernel.org]
>
> David K?gedal wrote:
>
>> @@ -123,6 +123,7 @@
>>  
>>  ;;;###autoload
>>  (defun git-blame-mode (&optional arg)
>> +  "Minor mode for displaying Git blame"
>>    (interactive "P")
>>    (if arg
>>        (setq git-blame-mode (eq arg 1))
>
> We should probably also change file description in header, and autoload
> instruction in Installation: section of commentary:

Agreed.

Show 13 quoted lines

> ;;; git-blame.el --- Minor mode for displaying Git blame  -*- coding: utf-8 -*-
> ;;
>
> [...]
>
> ;; If you do not want to load this package before it is necessary, you
> ;; can make use of the `autoload' feature, e.g. by adding to your .emacs
> ;; the following lines
> ;;
> ;;    (autoload 'git-blame-mode "git-blame"
> ;;              "Minor mode for displaying Git blame" t)
>
> (docstring is needed because INTERACTIVE is _fourth_ parameter).

Yes? Of course you need the doc string here, since the file isn't loaded yet.

-- 
David Kågedal