Re: [PATCH] unexpected Make output (e.g. from --debug) causes build failure

From: David Kastrup <dak@gnu.org>
Date: Sep 25, 2007, 07:59 UTC
Message-ID: <86zlzbrx9a.fsf@lola.quinscape.zz>
In-Reply-To: <877imftfef.fsf@rho.meyering.net>

Jim Meyering <jim@meyering.net> writes:

Show 23 quoted lines

> Without this, the extra output produced e.g., by "make --debug"
> would go into $INSTLIBDIR and then cause the sed command to fail.
>
> Signed-off-by: Jim Meyering <jim@meyering.net>
> ---
>  Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 0055eef..97ce687 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -805,7 +805,7 @@ perl/perl.mak: GIT-CFLAGS
>
>  $(patsubst %.perl,%,$(SCRIPT_PERL)): % : %.perl
>  	$(QUIET_GEN)$(RM) $@ $@+ && \
> -	INSTLIBDIR=`$(MAKE) -C perl -s --no-print-directory instlibdir` && \
> +	INSTLIBDIR=`MAKEFLAGS= $(MAKE) -C perl -s --no-print-directory instlibdir` && \
>  	sed -e '1{' \
>  	    -e '	s|#!.*perl|#!$(PERL_PATH_SQ)|' \
>  	    -e '	h' \
> --
> 1.5.3.2.99.ge4b2-dirty

Does this work with "make -n" ?

-- 
David Kastrup